cpu/saml1x: fix adc resolution issue#11972
Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom Aug 7, 2019
Merged
Conversation
dylad
added
Type: enhancement
PeterKietzmann
approved these changes
Aug 7, 2019
Member
PeterKietzmann
left a comment
PeterKietzmann
left a comment
There was a problem hiding this comment.
ACK. Tested with tests/periph_adc setting ADC_RES_8BIT, ADC_RES_10BIT and ADC_RES_12BIT. Everything works smooth and ranges look as expected (I only applied 0V and 3.3V)
PeterKietzmann
added
the
CI: ready for build
PeterKietzmann
approved these changes
Aug 7, 2019
Member
PeterKietzmann
left a comment
PeterKietzmann
left a comment
There was a problem hiding this comment.
ACK and go. Thanks @dylad for addressing this issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds missing adc resolution enum for SAML1X family.
I cannot fully test this PR before submitting it because I have a very limited access to my hardware for the time being.
Testing procedure
Can be tested using tests/periph_adc, check if result is conform with input voltage applied and if value is between 0 and 1023 (if 10-bit resolution selected)
Issues/PRs references
Should fixes @PeterKietzmann's comment from #11892